[FIXED] - [5965] JCommonHTML::selectState JS syntax error - Joomla! Forum - community, help and support

revision: 5965
class: jcommonhtml
method: selectstate()

description: 

the code state filter broken.  i'm seeing problem in article manager own component.  if 1 tries filter state, firefox report following.

error: document.adminform.submitform not function
source file: http://joomla/administrator/index.php?o ... om_content
line: 1

i don't see reason why submitform should called - other filters use submit().

current code:

code: select all

   function selectstate( $filter_state='*', $published='published', $unpublished='unpublished', $archived=null )
   {
...
      return jhtmlselect::genericlist( $state, 'filter_state', 'class="inputbox" size="1" onchange="document.adminform.submitform( );"', 'value', 'text', $filter_state );
   }


fix:

code: select all

      return jhtmlselect::genericlist( $state, 'filter_state', 'class="inputbox" size="1" onchange="document.adminform.submit( );"', 'value', 'text', $filter_state );


i think better solution omit onchange entirely.  currently, when 1 selects filter, form submits.  there many times when want apply or reset several filters @ once.  instead of using submit(), recommend removing onchange tag dropdown filters , adding "filter" button right of them.  alternatively, add $tag_attribs argument selectstate() developers can use function without onchange behavior.

tcp

fixed on svn.